DEVOPS-1066: use newer pr_jira_actions workflow#139
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the repository’s PR-to-JIRA GitHub Actions integration to use the newer reusable workflow from MiraGeoscience/CI-tools, aligning PR event handling with the updated workflow interface.
Changes:
- Switch workflow trigger from
pull_request_target(opened only) topull_requestwith additional PR event types. - Update reusable workflow reference from
reusable-jira-pr_add_jira_summary.yml@v2toreusable-jira-pr_actions.yml@v3. - Rename the job accordingly and adjust secrets ordering.
Comments suppressed due to low confidence (2)
.github/workflows/pr_jira_actions.yml:9
- This workflow no longer restricts execution to the MiraGeoscience org (the previous job used
if: startsWith(github.repository, 'MiraGeoscience/')). Other workflows that call MiraGeoscience/CI-tools (e.g.,.github/workflows/issue_to_jira.yml) keep this guard to avoid running in upstream/forks where JIRA secrets may not exist. Consider reintroducing the repo/org check (or another explicit condition) so the job doesn’t run (and fail noisily) outside MiraGeoscience-owned repos.
.github/workflows/pr_jira_actions.yml:7 - This workflow dropped the top-level
permissions: {}hardening that is used in other workflows in this repo (e.g.,.github/workflows/security_scan.yml:20,.github/workflows/issue_to_jira.yml:7). Even though the job sets its own permissions, adding an explicit top-level permissions block helps avoid relying on repository-default GITHUB_TOKEN permissions and keeps the repo’s workflow security posture consistent.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEVOPS-1066 - use CI-tools v3 in all the repos